Fix dark-theme ComboBox contrast and flatten button appearance Preset ComboBoxes in both control panels drew near-white item text without a matching buttonFill/listFill, so they fell back to SceneryStack's default white chrome — near-invisible against the default (dark) color profile. Give them dark buttonFill/listFill from SolarSystemModelsColors, matching the pattern already used in OscillationsAndChaos. Also add SolarSystemModelsButtonOptions.ts with a FlatAppearanceStrategy bundle (mirroring RotatingSky's RotatingSkyButtonOptions.ts) and apply it to every RectangularPushButton, ResetAllButton, and TimeControlNode play/pause/step button so the sim uses a flat button look instead of SceneryStack's default 3-D bevel. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018svZaRUmD44JWTQJLUYdmx#7
Merged
Conversation
Preset ComboBoxes in both control panels drew near-white item text without a matching buttonFill/listFill, so they fell back to SceneryStack's default white chrome — near-invisible against the default (dark) color profile. Give them dark buttonFill/listFill from SolarSystemModelsColors, matching the pattern already used in OscillationsAndChaos. Also add SolarSystemModelsButtonOptions.ts with a FlatAppearanceStrategy bundle (mirroring RotatingSky's RotatingSkyButtonOptions.ts) and apply it to every RectangularPushButton, ResetAllButton, and TimeControlNode play/pause/step button so the sim uses a flat button look instead of SceneryStack's default 3-D bevel. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018svZaRUmD44JWTQJLUYdmx
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Related issues
Fixes #
Related to #
Testing
npm run lintnpm run checknpm run buildnpm test(if applicable)How to test
Checklist