ci: drop hardcoded repo-name from the compliance check#6
Merged
Conversation
The shared compliance workflow already defaults to the calling repository's name, so passing it explicitly is redundant — and three sims (ExtrasolarPlanets, RotatingSky, SolarSystemModels) were still passing the stale 'TemplateSingleSim' value inherited from the template, running their compliance checks under the wrong identity. Relying on the default also keeps future template forks correct. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vz7L7hZ5S846diqgQDqxX9
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared compliance workflow already defaults to the calling repository's name, so passing it explicitly is redundant — and three sims (ExtrasolarPlanets, RotatingSky, SolarSystemModels) were still passing the stale 'TemplateSingleSim' value inherited from the template, running their compliance checks under the wrong identity. Relying on the default also keeps future template forks correct.
Claude-Session: https://claude.ai/code/session_01Vz7L7hZ5S846diqgQDqxX9
Description
Type of change
Related issues
Fixes #
Related to #
Testing
npm run lintnpm run checknpm run buildnpm test(if applicable)How to test
Checklist