Hoist all hardcoded strings to StringManager i18n and colors to SolarSystemModelsColors#2
Merged
Conversation
…SystemModelsColors Strings: - Add `zodiac` section (12 sign names) to all 3 locale JSON files (EN/FR/ES) - Add `configurations.au`, `configurations.pausedFor` to all locales - Expose `getZodiacStrings()` on StringManager - PtolemaicTimeReadout: use `yearsStringProperty`/`daysStringProperty` via Multilink - ConfigurationsTimeReadout: replace imperative string building with DerivedProperty composed from model properties + string properties; import DAYS_PER_YEAR from constants - ConfigurationsScreenView: include `auStringProperty` in orbit-label Multilink - PtolemaicScreenView, PtolemaicZodiacStrip, ConfigurationsZodiacStrip: replace hardcoded ZODIAC_SIGNS/SIGN_NAMES arrays with per-sign string properties Colors (14 new ProfileColorProperty entries in SolarSystemModelsColors): - `orbitAreaBackgroundColorProperty` — dark sky behind both orbit diagrams - `zodiacTickColorProperty` — tick marks at sign boundaries - `zodiacLabelColorProperty` — zodiac sign labels (ring + strip) - `zodiacBorderColorProperty` — zodiac strip border (ConfigurationsZodiacStrip) - `zodiacDividerColorProperty` — divider lines between sign segments - `constellationLineColorProperty` — stick-figure lines in both ZodiacConstellationNode and ZodiacStrip - `constellationStarColorProperty` — star dot fills in ZodiacConstellationNode - `sunOrbitReferenceColorProperty` — faint reference circle in Ptolemaic view - `timelineBackgroundColorProperty` — ConfigurationsTimeline bg - `timelineBorderColorProperty` — ConfigurationsTimeline border - `timelineEventColorProperty` — event mark lines - `timelineSelectedColorProperty` — selected event highlight - `timelineCursorColorProperty` — time cursor line - `timelineLabelColorProperty` — event label text Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016d5GzzgzLDv3mCVaG7C4BX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strings:
zodiacsection (12 sign names) to all 3 locale JSON files (EN/FR/ES)configurations.au,configurations.pausedForto all localesgetZodiacStrings()on StringManageryearsStringProperty/daysStringPropertyvia Multilinkcomposed from model properties + string properties; import DAYS_PER_YEAR from constants
auStringPropertyin orbit-label Multilinkreplace hardcoded ZODIAC_SIGNS/SIGN_NAMES arrays with per-sign string properties
Colors (14 new ProfileColorProperty entries in SolarSystemModelsColors):
orbitAreaBackgroundColorProperty— dark sky behind both orbit diagramszodiacTickColorProperty— tick marks at sign boundarieszodiacLabelColorProperty— zodiac sign labels (ring + strip)zodiacBorderColorProperty— zodiac strip border (ConfigurationsZodiacStrip)zodiacDividerColorProperty— divider lines between sign segmentsconstellationLineColorProperty— stick-figure lines in both ZodiacConstellationNode and ZodiacStripconstellationStarColorProperty— star dot fills in ZodiacConstellationNodesunOrbitReferenceColorProperty— faint reference circle in Ptolemaic viewtimelineBackgroundColorProperty— ConfigurationsTimeline bgtimelineBorderColorProperty— ConfigurationsTimeline bordertimelineEventColorProperty— event mark linestimelineSelectedColorProperty— selected event highlighttimelineCursorColorProperty— time cursor linetimelineLabelColorProperty— event label textCo-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_016d5GzzgzLDv3mCVaG7C4BX