Skip to content

[12.0][FIX] queue_job: don't enqueue dependent jobs after a retryable postpone (closed cursor) #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MiquelRForgeFlow wants to merge 1 commit into
base: 12.0
Choose a base branch
from
+6 −0
Open

[12.0][FIX] queue_job: don't enqueue dependent jobs after a retryable postpone (closed cursor) #944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions queue_job/controllers/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,12 @@ def retry_postpone(job, message, seconds=None):
# traceback in the logs we should have the traceback when all
# retries are exhausted
env.cr.rollback()
# A postponed job is not done: it must not release its dependent
# jobs. Returning here also avoids calling _enqueue_dependent_jobs
# with job.env pointing to the now-closed cursor that
# retry_postpone() opened and closed, which would raise
# "Unable to use a closed cursor".
return ""

except (FailedJobError, Exception) as orig_exception:
buff = StringIO()
Expand Down
Loading