Raise a clear error on ABF files whose header reports an impossible signal size (integer overflow)#1867
Open
h-mayorquin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an ABF file's header reports more data than the file can actually hold,
AxonRawIOdoes the segment offset and size arithmetic in fixed-width integers that silently overflow, soparse_header()succeeds and reports a garbage (or even negative) signal size. The failure then surfaces far from its cause: a downstream read either crashes deep in the data path with an opaquemmap length is greater than file size, naming neither the file nor the reason, or in the worst case reads out of bounds and hands back wrong data with no error at all. This bit both @luiztauffer and me while writing ABF converters,This change does the offset and size arithmetic in arbitrary-precision Python integers so it can no longer wrap, and validates the implied data extent against the file on disk during parsing. A damaged header is now rejected at the earliest possible point with an explicit error that names the file and says the header is corrupt or truncated, instead of parsing clean and detonating later (or silently). The error stays within the existing neo exception hierarchy, so callers that already guard their reads keep skipping bad files exactly as before, now with a message that actually explains what went wrong. Regression coverage uses two purpose-crafted fixtures on gin, one inflating the size into an overflow and one carrying a negative length, each asserting the specific error it should produce.