fix(web): keep Sidebar single-root so collapse hides it#1406
Merged
Conversation
A top-level Teleport in the sidebar template made the component multi-root, so v-show could not apply display:none and the collapsed sidebar stayed mounted at the rail width, squeezing the conversation. Move the teleport inside the aside so the sidebar is single-root again.
🦋 Changeset detectedLatest commit: 67fb48c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue — reported and fixed directly from the web UI.
Problem
Collapsing the sidebar in the web UI left it mounted at the rail width instead of hiding it, so the session list got squashed into a narrow column of clipped icons and the conversation pane was pushed aside. Root cause: a top-level
<Teleport>in the sidebar template made the component multi-root, sov-showcould not applydisplay:noneto a Fragment and silently did nothing.What changed
Moved the teleport inside the sidebar
<aside>so the component is single-root again andv-showhides it correctly on collapse. The teleported overlay still renders tobody, so its behavior is unchanged. Changeset included.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.