fix: accept music-cover-free model and differentiate network errors#184
Open
MeloMei wants to merge 1 commit into
Open
fix: accept music-cover-free model and differentiate network errors#184MeloMei wants to merge 1 commit into
MeloMei wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #182.
Three fixes for the
mmx music covercommand:music-cover-freetoVALID_COVER_MODELS(models.ts) andVALID_MODELS(cover.ts) so free-tier users can use the cover feature.handler.ts, route network-levelETIMEDOUTerrors toExitCode.TIMEOUTinstead ofExitCode.NETWORK, and appenderr.cause.codeto generic network error messages for better diagnostics.--modeloption description to document bothmusic-cover(paid) andmusic-cover-free(free tier).Changes
src/commands/music/models.ts— addedmusic-cover-freeto valid cover model setsrc/commands/music/cover.ts— addedmusic-cover-freeto inline validation + updated help textsrc/errors/handler.ts— ETIMEDOUT routes to TIMEOUT exit code; include cause code in network error messageTests
musicCoverModel accepts music-cover-free as defaultaccepts music-cover-free model in dry-runnetwork-level ETIMEDOUT error routes to TIMEOUT exit codegeneric network error includes cause code when availableAll 362 existing tests still pass (2 pre-existing failures unrelated to this change).