Skip to content

fix: accept music-cover-free model and differentiate network errors#184

Open
MeloMei wants to merge 1 commit into
MiniMax-AI:mainfrom
MeloMei:fix/music-cover-bugs
Open

fix: accept music-cover-free model and differentiate network errors#184
MeloMei wants to merge 1 commit into
MiniMax-AI:mainfrom
MeloMei:fix/music-cover-bugs

Conversation

@MeloMei

@MeloMei MeloMei commented Jun 26, 2026

Copy link
Copy Markdown

Summary

Closes #182.

Three fixes for the mmx music cover command:

  1. Model whitelist: Add music-cover-free to VALID_COVER_MODELS (models.ts) and VALID_MODELS (cover.ts) so free-tier users can use the cover feature.
  2. Network error differentiation: In handler.ts, route network-level ETIMEDOUT errors to ExitCode.TIMEOUT instead of ExitCode.NETWORK, and append err.cause.code to generic network error messages for better diagnostics.
  3. Help text: Update --model option description to document both music-cover (paid) and music-cover-free (free tier).

Changes

  • src/commands/music/models.ts — added music-cover-free to valid cover model set
  • src/commands/music/cover.ts — added music-cover-free to inline validation + updated help text
  • src/errors/handler.ts — ETIMEDOUT routes to TIMEOUT exit code; include cause code in network error message

Tests

  • Added: musicCoverModel accepts music-cover-free as default
  • Added: accepts music-cover-free model in dry-run
  • Added: network-level ETIMEDOUT error routes to TIMEOUT exit code
  • Added: generic network error includes cause code when available

All 362 existing tests still pass (2 pre-existing failures unrelated to this change).

Copilot AI review requested due to automatic review settings June 26, 2026 07:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mmx music cover: 4 CLI bugs vs API behavior (model whitelist, error code overloading, missing flags, missing docs)

2 participants