refactor(smart-transactions-controller): import AuthenticationController namespace#9167
Open
cryptodev-2s wants to merge 2 commits into
Open
refactor(smart-transactions-controller): import AuthenticationController namespace#9167cryptodev-2s wants to merge 2 commits into
cryptodev-2s wants to merge 2 commits into
Conversation
…ler namespace Switch the bearer token action type to the AuthenticationController namespace from the main profile-sync-controller entry instead of the /auth subpath, and consolidate the TransactionParams type into the existing import group.
cryptodev-2s
temporarily deployed
to
default-branch
GitHub Actions
Inactive
The import refactor removed the lines that triggered the no-base-to-string and restrict-template-expressions violations, so their suppression entries no longer apply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The smart-transactions-controller imported the bearer token action type from the
@metamask/profile-sync-controller/authsubpath. This change switches it to theAuthenticationControllernamespace exported from the package's main entry, which keeps the type reference aligned with how the rest of the namespace is consumed. While here, theTransactionParamstype import was folded into the existing@metamask/transaction-controllerimport group instead of sitting on its own line.This is an internal-only type import refactor. There is no change to runtime behavior or the public API surface, so no changelog entry is needed.
References
Checklist