fix(transaction-pay-controller): submit direct mUSD fiat deposits#9161
Draft
matthewwalsh0 wants to merge 9 commits into
Draft
fix(transaction-pay-controller): submit direct mUSD fiat deposits#9161matthewwalsh0 wants to merge 9 commits into
matthewwalsh0 wants to merge 9 commits into
Conversation
321f6ed to
3dde93c
Compare
4636045 to
b47ac27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Direct mUSD fiat quotes for Money Account deposits can settle directly into the Money Account, so they do not need a Relay quote or Relay execute path.
This PR moves that path to a Ramps-funded, sponsored Money Account vault batch. After fiat settlement, the Fiat strategy refreshes the vault calldata through
getAmountData, submits the nested approve/deposit calls throughTransactionController:addTransactionBatch, and lets the client publish hook handle 7702/Sentinel sponsorship.It also keeps a local QA funding path behind client-provided fiat test options so the settlement step can be exercised without creating a real on-ramp order.
References
Checklist