[bot] Fast-forward for 26.3.13#1151
Merged
Merged
Conversation
## Rationale
Submitting the EHR "Save As Template" dialog with every field unchecked
threw an uncaught `TypeError: Cannot read properties of undefined
(reading 'length')`. The checkboxgroup's `getValue().fields` is
`undefined` when nothing is selected, so reading `.length` crashed
`onSubmit` — the user got a silent failure (the template was never
saved) plus a console error, instead of any guidance.
## Related Pull Requests
None.
## Changes
- Guard the selected-field list before reading `.length`, so an empty
selection no longer throws.
- Evaluate the record-selector `'none'` case before the field check, so
a section the user intends to save is distinguished from one explicitly
excluded.
- When no fields are selected, show a clear validation message ("At
least one field is required and none are selected. Note: The field can
be blank.") instead of the generic "No records selected" alert.
…1147) ## Rationale kinship2's QP-based alignment (align=TRUE) can fail with "constraints are inconsistent, no solution!" on deep or looped pedigrees, which aborts the entire Pedigree report so no image renders at all. ## Related Pull Requests None. ## Changes - Wrap the kinship2 `plot()` call in the Pedigree report in `tryCatch`, retrying once with `align=FALSE` when the alignment error is detected so the report still renders. Any other error is re-raised unchanged.
labkey-tchad
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated automatically.
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
View all PRs: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=26.3_ff_bot_26.3.13