Skip to content

Move legacy landing pages and forms to legacy_landing_pages endpoint#124

Merged
n7studios merged 3 commits into
mainfrom
use-legacy-landing-pages-endpoint
Jul 3, 2026
Merged

Move legacy landing pages and forms to legacy_landing_pages endpoint#124
n7studios merged 3 commits into
mainfrom
use-legacy-landing-pages-endpoint

Conversation

@ciccio-kit

@ciccio-kit ciccio-kit commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Moves the WordPress libraries off the landing_pages API endpoint, which the monolith is about to repurpose. Both methods that hit it now call the new byte-identical legacy_landing_pages endpoint (Kit/convertkit#44872, confirmed live in production):

  • get_legacy_landing_pages()type => hosted
  • get_legacy_forms()type => embed

The new endpoint supports both type filters and returns the same shape (keyed legacy_landing_pages, same pagination object), so nothing else changes. After this, no code calls the old landing_pages endpoint.

This is shared library code (convertkit-wordpress / wpforms / membermouse) — releasing needs a new tag (next: 2.1.7) and a composer bump in each consuming plugin.

Testing

No test changes are required: the integration tests already exercise both methods and assert on the legacy_landing_pages response key — APITest::testGetLegacyLandingPages / testGetLegacyLandingPagesWithTotalCount, testGetLegacyForms / testGetLegacyFormsWithTotalCount, and ResourceTest::testRefreshLandingPages (which drives get_legacy_landing_pages() via refresh()). None hardcode the endpoint path, so the switch is transparent.

Checklist

@ciccio-kit ciccio-kit changed the title Use legacy_landing_pages endpoint for legacy landing pages Move legacy landing pages and forms to legacy_landing_pages endpoint Jul 1, 2026
@ciccio-kit ciccio-kit marked this pull request as ready for review July 1, 2026 15:39
@ciccio-kit ciccio-kit requested a review from n7studios July 1, 2026 15:39

@n7studios n7studios left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR. Tests are failing due to other API changes, which I'll resolve in another PR.

@n7studios n7studios merged commit edb9b1a into main Jul 3, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants