Move legacy landing pages and forms to legacy_landing_pages endpoint#124
Merged
Conversation
n7studios
approved these changes
Jul 2, 2026
n7studios
left a comment
Contributor
There was a problem hiding this comment.
Thanks for submitting this PR. Tests are failing due to other API changes, which I'll resolve in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the WordPress libraries off the
landing_pagesAPI endpoint, which the monolith is about to repurpose. Both methods that hit it now call the new byte-identicallegacy_landing_pagesendpoint (Kit/convertkit#44872, confirmed live in production):get_legacy_landing_pages()—type => hostedget_legacy_forms()—type => embedThe new endpoint supports both
typefilters and returns the same shape (keyedlegacy_landing_pages, samepaginationobject), so nothing else changes. After this, no code calls the oldlanding_pagesendpoint.This is shared library code (convertkit-wordpress / wpforms / membermouse) — releasing needs a new tag (next:
2.1.7) and a composer bump in each consuming plugin.Testing
No test changes are required: the integration tests already exercise both methods and assert on the
legacy_landing_pagesresponse key —APITest::testGetLegacyLandingPages/testGetLegacyLandingPagesWithTotalCount,testGetLegacyForms/testGetLegacyFormsWithTotalCount, andResourceTest::testRefreshLandingPages(which drivesget_legacy_landing_pages()viarefresh()). None hardcode the endpoint path, so the switch is transparent.Checklist