Implement maximize/minimize and float/unfloat window controls#23
Open
Jeshwin wants to merge 9 commits into
Open
Implement maximize/minimize and float/unfloat window controls#23Jeshwin wants to merge 9 commits into
Jeshwin wants to merge 9 commits into
Conversation
Maximize/minimize: - Add ephemeral maximizedPath context state. - maximize button toggles to minimize; a maximized window overrides its layout position to fill the container at elevated z-index while all other windows stay in place (Window.tsx, WindowToolbar.tsx). Float/unfloat: - Add ephemeral floatingWindows context state + FloatingWindowData type. - float button removes the window from the layout and adds it to a floating layer at its current size. - New FloatingWindow component: drag by topbar, resize from any edge/corner, click-to-focus raises z-index, per-window tab selection. - unfloat moves all tabs into the layout window under the float's center (layoutGeometry.ts hit-testing); falls back to seeding a root window when the layout is empty. - Add FloatIcon/UnfloatIcon, 'float'/'unfloat' ToolbarButtonType, default non-mutable buttons now [float, maximize, misc], and floating-window styles.
All maximize/minimize and float/unfloat items are implemented and verified (tsc, lint, vitest all pass).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the maximize/minimize and float/unfloat toolbar buttons (previously placeholders).
Maximize / Minimize
maximizedPathcontext state.maximizebutton toggles tominimize. A maximized window overrides its layout position to fill the container at elevated z-index, while all other windows stay in their exact positions.Float / Unfloat
floatingWindowscontext state +FloatingWindowDatatype.floatbutton removes the window from the layout and adds it to a floating layer at its current calculated size.FloatingWindowcomponent: drag by topbar, resize from any edge/corner, click-to-focus raises z-index, per-window tab selection.unfloatmoves all tabs into the layout window under the float's center (hit-testing inlayoutGeometry.ts); falls back to seeding a root window when the layout is empty.FloatIcon/UnfloatIcon,float/unfloatToolbarButtonType, and floating-window styles. Default non-mutable buttons are now[float, maximize, misc].State is ephemeral
Maximize/float state is intentionally not persisted to localStorage.
Integration note
Targets
issues/main(notmain). TouchesWindowToolbar.tsx/types.ts/LaymanContext.tsxlike the props PR — expect minor merge conflicts, and wire these buttons into theshowTabsellipsis popover during integration.