Make agent memory respect crew_memory_enabled config (ar-i84f)#22
Merged
Conversation
All 12 seller agent constructors hardcoded `memory=True`, ignoring `settings.crew_memory_enabled`. This forces crewai to attach a search_memory tool requiring OpenAI embeddings via chromadb. When CHROMA_OPENAI_API_KEY is absent (the default for non-OpenAI deployments), agent tool calls fail silently downstream. Fix: replace hardcoded `memory=True` with `memory=settings.crew_memory_enabled` in all 12 agent files (L1 inventory_manager + 6 L2 inventory agents + 5 L3 specialist agents). Settings default remains True so existing users see no behavior change. Mirrors the buyer-side fix (IABTechLab/buyer-agent#104). Discovered 2026-05-29 during EOD smoke test (ar-r82f.15) Surface A. bead: ar-i84f Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All 12 seller agent constructors hardcoded
memory=True, ignoringsettings.crew_memory_enabled. That hardcode forces crewai to attach asearch_memorytool backed by chromadb + OpenAI embeddings, which fails at runtime whenCHROMA_OPENAI_API_KEYis absent.Fix
Replace hardcoded
memory=Truewithmemory=settings.crew_memory_enabledin all 12 agent files:inventory_manager.pyctv_inventory_agent,display_inventory_agent,linear_tv_inventory_agent,mobile_app_inventory_agent,native_inventory_agent,video_inventory_agentaudience_validator_agent,availability_agent,pricing_agent,proposal_review_agent,upsell_agentSettings default remains
crew_memory_enabled = True, so users with an OpenAI embedder configured see no behavior change.Mirrors the buyer-side fix at IABTechLab/buyer-agent#104.
Context
Discovered 2026-05-29 during EOD smoke test (
ar-r82f.15) Surface A.bead: ar-i84f
🤖 Generated with Claude Code