Skip to content

Feat: Select welcome-select windows#540

Open
JavierRibaldelRio wants to merge 22 commits into
developfrom
control-station/multiple-select-app
Open

Feat: Select welcome-select windows#540
JavierRibaldelRio wants to merge 22 commits into
developfrom
control-station/multiple-select-app

Conversation

@JavierRibaldelRio

@JavierRibaldelRio JavierRibaldelRio commented Jun 15, 2026

Copy link
Copy Markdown
Contributor
image

@JavierRibaldelRio JavierRibaldelRio added Frontend javascript Pull requests that update javascript code labels Jun 15, 2026
@JavierRibaldelRio JavierRibaldelRio marked this pull request as ready for review June 15, 2026 23:32
@maximka76667

Copy link
Copy Markdown
Contributor

When I first open testing-view, then go back and open testing-view again application crashes

image

@maximka76667

Copy link
Copy Markdown
Contributor

You could consider adding a test that will verify this behavior in E2E and modifying e2e tests so they pass

Comment thread electron-app/src/app/modeSelector.js Outdated
Comment thread electron-app/src/ipc/handlers.js Outdated
@JavierRibaldelRio

Copy link
Copy Markdown
Contributor Author

When I first open testing-view, then go back and open testing-view again application crashes
image

Thats because is does not exists.

@JavierRibaldelRio

Copy link
Copy Markdown
Contributor Author

It seems I have messed up a little bit with GitHub, sorry

You could consider adding a test that will verify this behavior in E2E and modifying e2e tests so they pass

I'll look at it. ;)

@maximka76667

Copy link
Copy Markdown
Contributor

When I first open testing-view, then go back and open testing-view again application crashes
image

Thats because is does not exists.

i think you misread my message

@JavierRibaldelRio

Copy link
Copy Markdown
Contributor Author

When I first open testing-view, then go back and open testing-view again application crashes
image

Thats because is does not exists.

@maximka76667 Solved.

When I first open testing-view, then go back and open testing-view again application crashes
image

Thats because is does not exists.

i think you misread my message

Solved, thanks, @maximka76667

@JavierRibaldelRio

Copy link
Copy Markdown
Contributor Author

@maximka76667 @Humanoidear

Finally,
Ready to review ;)

(BLCU view will be implemented in a new branch)

@JavierRibaldelRio

JavierRibaldelRio commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@maximka76667 I am really busy with BLCU, and logging view.

Would you mind modify the E2E test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants