fix(check-in): hide attendee email from public resource#1229
Open
realicon23 wants to merge 1 commit into
Open
Conversation
Public check-in list URLs act as capability links for check-in staff. They need enough attendee information to identify tickets, but exposing email addresses through the unauthenticated public attendee resource increases the blast radius if a link is shared or logged. Remove email from AttendeeWithCheckInPublicResource while keeping authenticated attendee resources unchanged, and add a focused resource test for the public response shape. Fixes HiEventsDev#1224
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #1224.
This removes
emailfrom the unauthenticated public check-in attendee resource and adds a focused unit test for the public response shape.Why
Public check-in list URLs work like capability links: anyone with the URL can access the public check-in attendee endpoints. Check-in staff need enough information to identify an attendee and process their ticket, but returning email addresses increases the privacy impact if a link is shared, logged, screenshotted, or otherwise exposed.
The narrowest change is to remove email from
AttendeeWithCheckInPublicResourcewhile leaving the authenticated attendee resource unchanged. This keeps organiser/admin workflows intact and reduces personal-data exposure on the public endpoint.Verification
/opt/homebrew/opt/php@8.4/bin/php -l backend/app/Resources/Attendee/AttendeeWithCheckInPublicResource.php/opt/homebrew/opt/php@8.4/bin/php -l backend/tests/Unit/Resources/Attendee/AttendeeWithCheckInPublicResourceTest.phpgit diff --check/opt/homebrew/opt/php@8.4/bin/php backend/vendor/bin/phpunit backend/tests/Unit/Resources/Attendee/AttendeeWithCheckInPublicResourceTest.php --no-coverage/opt/homebrew/opt/php@8.4/bin/php backend/vendor/bin/phpunit backend/tests/Unit/Resources --no-coverage/opt/homebrew/opt/php@8.4/bin/php backend/vendor/bin/phpunit backend/tests/Unit/Services/Application/Handlers/CheckInList/Public --no-coverage