Skip to content

reactor wit vendor subtree#151

Merged
ruslanti merged 4 commits into
mainfrom
refactor/reactor-wit-vendor-subtree
Jun 24, 2026
Merged

reactor wit vendor subtree#151
ruslanti merged 4 commits into
mainfrom
refactor/reactor-wit-vendor-subtree

Conversation

@ruslanti

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings June 23, 2026 13:53
@ruslanti ruslanti self-assigned this Jun 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR transitions the reactor WIT definitions from a git submodule to a vendored git subtree, making the repository self-contained for builds and updating documentation/CI accordingly.

Changes:

  • Vendor crates/reactor/wit/ directly in-repo (with subtree sync instructions) and remove the .gitmodules submodule configuration.
  • Add the FastEdge WIT package/interfaces under crates/reactor/wit/.
  • Update GitHub Actions workflows to checkout without submodules (and bump actions/checkout major version).

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
README.md Updates setup docs to reflect WIT being vendored via subtree and provides subtree refresh command.
crates/reactor/wit/world.wit Adds the WIT world definition importing/exporting reactor interfaces.
crates/reactor/wit/utils.wit Adds the utils interface definition.
crates/reactor/wit/secret.wit Adds the secret interface definition and error model.
crates/reactor/wit/README.md Documents subtree syncing/add/pull commands for the vendored WIT directory.
crates/reactor/wit/LICENSE Adds Apache-2.0 license for the vendored WIT subtree.
crates/reactor/wit/key-value.wit Adds the key-value store interface and related error definitions.
crates/reactor/wit/http.wit Adds HTTP request/response types and related enums.
crates/reactor/wit/http-handler.wit Adds the http-handler interface (request→response).
crates/reactor/wit/http-client.wit Adds the http-client interface (request→result).
crates/reactor/wit/dictionary.wit Adds the dictionary interface definition.
crates/reactor/wit/cache-types.wit Adds shared cache types/errors used by cache interfaces.
crates/reactor/wit/cache-sync.wit Adds synchronous cache interface using shared cache types.
CLAUDE.md Updates repository setup guidance to match subtree vendoring (no submodule step).
.gitmodules Removes the crates/reactor/wit submodule configuration.
.github/workflows/release.yaml Updates checkout step to not fetch submodules; bumps actions/checkout major.
.github/workflows/create_release_pr.yaml Updates checkout step to not fetch submodules; bumps actions/checkout major.
.github/workflows/ci.yaml Updates checkout step to not fetch submodules; bumps actions/checkout major.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/reactor/wit/utils.wit Outdated
Comment thread crates/reactor/wit/dictionary.wit Outdated
Comment thread crates/reactor/wit/key-value.wit Outdated
Comment thread .github/workflows/ci.yaml
ruslanti and others added 2 commits June 23, 2026 17:15
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.

@ruslanti ruslanti marked this pull request as ready for review June 23, 2026 14:29
@ruslanti ruslanti requested a review from godronus June 23, 2026 14:30
@ruslanti ruslanti merged commit f433b29 into main Jun 24, 2026
5 of 7 checks passed
@ruslanti ruslanti deleted the refactor/reactor-wit-vendor-subtree branch June 24, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants