Stale Cache Causing Night Sky to Disappear#50
Open
SoulSilverJD wants to merge 1 commit into
Open
Conversation
I've have come to terms with tile properties simply being overwritten in some shape or form, while the cache does work I failed to add a case where the tile properties are not applied or lost. This should fix the bug with the disappearing Night_Sky_Sheet on certain maps by first validating if the property is applied if a cache is in play.
Contributor
Author
|
Hello, hope your having a great day. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've have come to terms with tile properties simply being overwritten in some shape or form, while the cache does work I failed to add a case where the tile properties are not applied or lost.
This should fix the bug with the disappearing Night_Sky_Sheet on certain maps by first validating that the property is applied if a cache is in play.