Skip to content

fix(Segment Membership): Oversized numeric traits fail identity seeding#7938

Merged
khvn26 merged 2 commits into
mainfrom
fix/segment-membership-oversized-int-traits
Jul 2, 2026
Merged

fix(Segment Membership): Oversized numeric traits fail identity seeding#7938
khvn26 merged 2 commits into
mainfrom
fix/segment-membership-oversized-int-traits

Conversation

@khvn26

@khvn26 khvn26 commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to #7937

The mapper now stores integer traits outside the Int64 range as strings, mirroring the Edge CDC behaviour.

How did you test this code?

Added unit test cases reproducing the bug.

@khvn26
fix(Segment Membership): Oversized numeric traits fail identity seeding
024a306 
clickhouse-driver infers Int64 for every Python int written to a JSON
column, so a numeric identity trait outside the signed Int64 range
overflows the wire format. Since the seed sends each batch as one block,
a single oversized trait fails the whole environment's INSERT.

Store integer traits outside the Int64 range as strings.

beep boop
@khvn26 khvn26 requested a review from a team as a code owner July 2, 2026 11:44
@khvn26 khvn26 requested review from emyller and removed request for a team July 2, 2026 11:44
@vercel

vercel Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Jul 2, 2026 12:07pm
flagsmith-frontend-preview Ignored Ignored Preview Jul 2, 2026 12:07pm
flagsmith-frontend-staging Ignored Ignored Preview Jul 2, 2026 12:07pm

Request Review

@github-actions github-actions Bot added api Issue related to the REST API fix labels Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7938 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7938 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7938 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-7938 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7938 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7938 Finished ✅ Results ✅

@github-actions

github-actions Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  34.6 seconds
commit  024a306
info  🔄 Run: #18023 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  40.1 seconds
commit  024a306
info  🔄 Run: #18023 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  42.7 seconds
commit  024a306
info  🔄 Run: #18023 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  55.4 seconds
commit  024a306
info  🔄 Run: #18023 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  17.6 seconds
commit  5378120
info  🔄 Run: #18024 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  32.5 seconds
commit  5378120
info  🔄 Run: #18024 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  6 passed

Details

stats  6 tests across 5 suites
duration  35 seconds
commit  5378120
info  🔄 Run: #18024 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  1 minute, 10 seconds
commit  5378120
info  🔄 Run: #18024 (attempt 1)

@codecov

codecov Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.63%. Comparing base (946df88) to head (5378120).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7938   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files        1497     1497           
  Lines       59141    59151   +10     
=======================================
+ Hits        58335    58345   +10     
  Misses        806      806

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

Zaimwa9
Zaimwa9 previously approved these changes Jul 2, 2026
View reviewed changes

@Zaimwa9 Zaimwa9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@github-actions github-actions Bot added fix and removed fix labels Jul 2, 2026
@khvn26 khvn26 merged commit cbc295a into main Jul 2, 2026
33 checks passed
@khvn26 khvn26 deleted the fix/segment-membership-oversized-int-traits branch July 2, 2026 12:15
@flagsmith-engineering flagsmith-engineering Bot mentioned this pull request Jul 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zaimwa9 Zaimwa9 Zaimwa9 approved these changes
@emyller emyller Awaiting requested review from emyller emyller is a code owner automatically assigned from Flagsmith/flagsmith-back-end

Assignees

@emyller emyller

Labels

api Issue related to the REST API fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khvn26 @Zaimwa9 @emyller