bugfix: findfirst: a device can not be a volume label …#259
Merged
Conversation
…if looking for volume label
There was a problem hiding this comment.
Pull request overview
This PR adjusts DosFindFirst()’s special-case device-name matching so that device paths are not returned when the caller is requesting a volume label search.
Changes:
- Gate the
IS_DEVICE“match device name” branch so it does not trigger for volume-label searches (D_VOLID).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1086
to
1089
| if (rc & IS_NETWORK) | ||
| rc = network_redirector_fp(REM_FINDFIRST, current_ldt); | ||
| else if (rc & IS_DEVICE) | ||
| else if (rc & IS_DEVICE && !(attr & D_VOLID)) /* DEVICE can't be a volume label */ | ||
| { |
Contributor
Author
|
Is the copilot review automatic now, or some option I set (I didn't uncheck)? curious |
Contributor
|
I've not seen it applied to any other project automatically, and it's not something I've added. |
Contributor
|
Have a look at this page, there are several places it can be. I looked but couldn't see anything set, but check your personal account settings too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… so don't match if looking for volume label