Additional quotient theory with user provided canon map#1058
Open
oskgo wants to merge 1 commit into
Open
Conversation
oskgo
force-pushed
the
migrate-to-quotient
branch
from
2d9a815 to
8da238f
Compare
oskgo
force-pushed
the
migrate-to-quotient
branch
from
8da238f to
2cb7f4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking for theories to migrate to quotients now that #1006 is fixed I found that
Matrix.ecaandDynMatrix.ecawere explicitly choosing the representatives for the quotient, but thatQuotient.ecdid not facilitate this.Matrix.ecaused an axiomatized definition andDynMatrix.ecaadded some glue on top of the cloned quotient.I add a new theory,
CanonQuotient, toQuotient.ecto facilitate this use case, requiring an idempotentcanonmap sending every element in each equivalence class to its representative. This simplifies the construction of matrices and vectors inDynMatrix.ecaand deaxiomatizesMatrix.eca.Rather than defining
CanonQuotientas an extension toEquivQuotientI do it the other way around becauseEquivQuotientwas already constructed by building an idempotentcanonmap.