Conversation
Contributor
Author
|
I suspect that the function |
#1056) When a quantified variable in a lemma statement is instantiated (e.g. `apply (eager_f_sample z)` substituting `y` -> `z`), the substitution only updated the *form-level* locals. Variables embedded inside **program statements** carried by the formula -- the `s1`/`s2` bodies of an `eager [...]` judgement, for instance -- live as *expression-level* locals and were left untouched, producing an incorrect statement substitution. In both substitution engines (`ecCoreSubst.f_bind_local` and `ecSubst.add_flocal`), when binding a form-local `x |-> t`, if `t` is translatable back to an expression we now also register the corresponding expression-local binding (`bind_elocal` / `add_elocal`). Forms that don't translate (`CannotTranslate`) are left as before. `tests/eager_call_instanciate.ec` reproduces the bug and now passes.
Member
|
@bgregoir By ignoring the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a quantified variable in a lemma statement is instantiated (e.g.
apply (eager_f_sample z)substitutingy->z), the substitution only updated the form-level locals. Variables embedded inside program statements carried by the formula -- thes1/s2bodies of aneager [...]judgement, for instance -- live as expression-level locals and were left untouched, producing an incorrect statement substitution.In both substitution engines (
ecCoreSubst.f_bind_localandecSubst.add_flocal), when binding a form-localx |-> t, iftis translatable back to an expression we now also register the corresponding expression-local binding (bind_elocal/add_elocal). Forms that don't translate (CannotTranslate) are left as before.tests/eager_call_instanciate.ecreproduces the bug and now passes.Closes #1056