Skip to content

Add dev mode for previewing components#228

Merged
VictoriaBeilsten-Edmands merged 3 commits into
mainfrom
vbe/add-dev-mode
Jun 23, 2026
Merged

Add dev mode for previewing components#228
VictoriaBeilsten-Edmands merged 3 commits into
mainfrom
vbe/add-dev-mode

Conversation

@VictoriaBeilsten-Edmands

@VictoriaBeilsten-Edmands VictoriaBeilsten-Edmands commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@akademy

akademy commented Jun 22, 2026

Copy link
Copy Markdown
Member

This looks great, but wondering if we reference the package, rather than the individual components.

I add this to package.json

"@diamondlightsource/sci-react-ui": "file://../",

Then reference the components as usual.

import { Bar } from '@diamondlightsource/sci-react-ui';`

which seemed to work, but I'm getting odd typescript errors for the components.

@akademy

akademy commented Jun 22, 2026

Copy link
Copy Markdown
Member

Actually, it's not a big deal. Maybe we can look into it some other time.

I'll approve.

akademy
akademy previously approved these changes Jun 22, 2026

@akademy akademy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A future update should include a kitchen sink...!

@VictoriaBeilsten-Edmands VictoriaBeilsten-Edmands merged commit 2dd30e4 into main Jun 23, 2026
2 checks passed
@VictoriaBeilsten-Edmands VictoriaBeilsten-Edmands deleted the vbe/add-dev-mode branch June 23, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants