Format profile repo pill counts with compact GitHub-style numbers#13
Open
mathetos wants to merge 1 commit into
Open
Format profile repo pill counts with compact GitHub-style numbers#13mathetos wants to merge 1 commit into
mathetos wants to merge 1 commit into
Conversation
Profile top-repo fork and star badges now use a shared formatter: grouped numbers below 1k, GitHub-style k/M compact values above that so large Octocat-style counts fit the pills. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3 by formatting fork and star counts on profile repo pills.
format_count()helper for badge-style numbers.number_format_i18n()(locale-aware grouping).1.1k,13.9k,158k) so large profiles like Octocat stay readable inside the pills.Why compact for pills only
The follow button and repo meta row already used full grouped numbers, which works in wider space. The profile repo pills are narrow, so matching GitHub's abbreviated style there felt like the right tradeoff.
Before and After
Test plan
Octocatand confirm fork/star pills show compact values (e.g.158k,13.9k) instead of raw digits.580).