Fix gm-unit: dynamically update size_cur when modifying body appearance#1582
Closed
sizzlins wants to merge 3 commits into
Closed
Fix gm-unit: dynamically update size_cur when modifying body appearance#1582sizzlins wants to merge 3 commits into
sizzlins wants to merge 3 commits into
Conversation
Fixes #5793. Manually calculates size_cur from size_base and body modifiers to emulate native DF scaling logic, fulfilling the 3-year-old TODO.
ab9rf
requested changes
Jun 24, 2026
| -- Update the world texture | ||
| self.target_unit.flags4.any_texture_must_be_refreshed = true | ||
|
|
||
| -- Manually recalculate body size |
Member
There was a problem hiding this comment.
this code is an exact duplicate of the code above. write a function and call it in both places. Don't Repeat Yourself.
Author
|
superseded by #1594 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5793.
This pull request implements the math to dynamically update size_cur when modifying body appearance values (Height, Broadness, Length) in gm-unit. Previously, modifying these values left size_cur untouched (fulfilling the 3-year-old TODO in editor_body.lua). It uses standard DF scaling integer math to perfectly match the engine's volume calculations.