feat(gradebook): import did-you-mean, conflict change-matrix, loading cues, and copy polish#8460
Closed
LWS49 wants to merge 1 commit into
Closed
feat(gradebook): import did-you-mean, conflict change-matrix, loading cues, and copy polish#8460LWS49 wants to merge 1 commit into
LWS49 wants to merge 1 commit into
Conversation
… cues, and copy polish
Collaborator
Author
|
Superseded by #8465 (import correctness + UX consolidated into a single import PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wizard UX for the external grade importer. The Verify step shows header mismatches with did-you-mean suggestions and a malformed-cell list, and identifies rows by their External ID with a resolved-name column for match confirmation. The conflict prompt is redesigned as a per-student matrix showing each changed cell old → new, dropping unchanged rows. Adds loading affordances, scroll handling for wide previews, typography fixes, a reassigned-identifier advisory, and copy polish throughout.
Design decisions
Regression prevention
Covers: the import wizard (template/roster/from-existing, out-of-range verify, did-you-mean, loading), and the conflict change-matrix table (struck-old/arrow/bold-new, em-dash for null sides and missing cells, new-fill vs existing fallback, header/row identity) (frontend suites green). No backend logic change (that is PR4a). Import-flow specs run on push/CI.
Screenshots worth adding: the redesigned conflict change-matrix, and the Verify step with a did-you-mean suggestion.