feat(gradebook): decimal-ceiling cap entry, over-max flags, and out-of-range warnings#8458
Closed
LWS49 wants to merge 1 commit into
Closed
feat(gradebook): decimal-ceiling cap entry, over-max flags, and out-of-range warnings#8458LWS49 wants to merge 1 commit into
LWS49 wants to merge 1 commit into
Conversation
Collaborator
Author
|
Superseded by #8464 (renamed to convention; also now carries the inline save-confirmation toast). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens grade entry and surfaces out-of-range data for external assessments. Grade and max entry are capped at the
decimal(5,2)ceiling at the input layer; negative manual entry is allowed (floor-at-zero presumes penalty columns) while non-numeric input is rejected at entry instead of being silently discarded. Over-max and below-zero grades show an inline indicator whose tooltip copy is weighted-view-aware (states the read-time capping consequence only when weighting is on). A persistent below-the-tabs banner aggregates how many grades across how many externals are outside their range. Max marks become read-only in the table (edited only via the panel's Edit prompt).Design decisions
Regression prevention
Covers:
outOfRangecomputation, the OutOfRangeAlert component, cap-at-2dp entry, below-zero icon presence/absence, weighted vs non-weighted tooltip copy, read-only max cell, and the GradebookIndex out-of-range summary (frontend suites green). No behavior change to stored grades (read-time only). Import controller/service specs run on push/CI.Screenshots worth adding: the out-of-range banner, and an over-max cell tooltip in weighted vs non-weighted view.