Skip to content

Autocomplete Implementation#1949

Open
FastestMolasses wants to merge 19 commits into
mainfrom
itembox
Open

Autocomplete Implementation#1949
FastestMolasses wants to merge 19 commits into
mainfrom
itembox

Conversation

@FastestMolasses

Copy link
Copy Markdown
Member

Description

Adds first iteration of the autocomplete feature.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Comment thread CodeEdit/Features/LSP/Service/LSPService+Events.swift Outdated
Comment thread CodeEdit/Features/Editor/AutoCompleteCoordinator.swift Outdated
@FastestMolasses FastestMolasses marked this pull request as ready for review December 30, 2024 04:17
@tom-ludwig tom-ludwig added the WIP This is work-in-progress label Feb 27, 2025
@thecoolwinter

Copy link
Copy Markdown
Collaborator

That last I just pushed should fix build errors. Going to merge once tests are passing and it looks ready to go

@thecoolwinter

Copy link
Copy Markdown
Collaborator

Looks like there's some bug with either requesting completion items or filtering them. If I have a swift script like:

let string = ""
string.spl

The LSP isn't returning split as an option for completions. Super weird, going to investigate more before merging.

@thecoolwinter

thecoolwinter commented Aug 19, 2025

Copy link
Copy Markdown
Collaborator

That last commi fixes the issue I mentioned. It turns out that language servers can opt-out of client-side filtering by setting the isIncomplete flag in the item response. This checks for that flag and disables filtering if it's detected.

@0xWDG 0xWDG requested review from a team, austincondiff and tom-ludwig June 15, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP This is work-in-progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants