Skip to content

docs: refresh Electrum protocol links and prune stale TODOs#228

Open
EddieHouston wants to merge 1 commit into
Blockstream:new-indexfrom
EddieHouston:chore/update-electrum-protocol-doc-links
Open

docs: refresh Electrum protocol links and prune stale TODOs#228
EddieHouston wants to merge 1 commit into
Blockstream:new-indexfrom
EddieHouston:chore/update-electrum-protocol-doc-links

Conversation

@EddieHouston

@EddieHouston EddieHouston commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

The ElectrumX docs at electrumx.readthedocs.io are effectively frozen around protocol 1.4.2. The maintained, canonical Electrum protocol spec now lives at spesmilo/electrum-protocol (rendered at electrum-protocol.readthedocs.io).

Doc-link refresh

Point the remaining references at the maintained docs:

  • README.md--electrum-hosts / server.features format link
  • src/config.rs--electrum-public-hosts CLI help text

The #server-features anchor was verified to resolve on the new docs.

Prune stale TODO.md items

  • "Update height to -1 for txns with any unconfirmed input" — already implemented by get_electrum_height (src/electrum/mod.rs), wired into get_history/get_mempool/status via has_unconfirmed_parents.
  • "Use generators instead of vectors" — obsolete; the codebase uses iterators throughout.

Remaining TODO items (DB snapshot for queries, bytes vs Vec<u8>, proper HTTP parser for JSONRPC replies, RocksDB tuning) are left as-is — they're still open.

Docs/help-text only; no behavior change.

Thanks to @SomberNight for pointing out that the up-to-date docs live at spesmilo/electrum-protocol.

@EddieHouston EddieHouston changed the title docs: point Electrum protocol links to spesmilo/electrum-protocol docs: refresh Electrum protocol links and prune stale TODOs Jun 17, 2026
@EddieHouston EddieHouston force-pushed the chore/update-electrum-protocol-doc-links branch from 2a33ec2 to 68b6f79 Compare June 17, 2026 14:39
  The ElectrumX docs (electrumx.readthedocs.io) are frozen ~1.4.2; the
  maintained spec now lives at electrum-protocol.readthedocs.io. Update the
  server.features references in README and the --electrum-hosts help text.

  Also prune two stale TODO.md items:
  - "height -1 for txns with unconfirmed inputs" -- already implemented by
    get_electrum_height.
  - "use generators instead of vectors" -- obsolete; iterators are used
    throughout.
@EddieHouston EddieHouston force-pushed the chore/update-electrum-protocol-doc-links branch from 68b6f79 to 7a0f158 Compare June 18, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants