fix: use query params for GET address-book methods

[seanchen0818]

Summary

• getConnections, getListingEntryContacts, and getListingEntryDirectory were using .send(params) on GET requests, which puts params in the request body — ignored by the server
• Replaced with .query(params) so filters are correctly sent as URL query params
• Confirmed against address-book service SDK spec: all three routes define filters under query:, not body:

Test plan

• Added unit tests for all three GET methods verifying .query() is called with the provided params
• All 4 tests pass locally

Fixes GN-2899

🤖 Generated with Claude Code

[linear-code]

GN-2899

[pranishnepal]

Tests failing

[lokesh-bitgo]

The core fix is correct — .send(params) on GET was silently dropping all filter params since most servers ignore the request body on GET requests. .query(params ?? {}) is the right approach. CI is green and the logic is sound.

Leaving a few non-blocking suggestions inline.

[lokesh-bitgo]

Nit (follow-up): getListing() (line ~82) also calls .send() on a GET with no arguments — same anti-pattern as the methods fixed here. Less harmful since there are no params to drop, but it's inconsistent in the same class. Consider cleaning it up in a follow-up: just remove the .send() call entirely since .get().set(...).result() is sufficient for a parameterless GET.

[seanchen0818]

updated!

[lokesh-bitgo]

Low: mockBitGo.get is stubbed to accept any URL — a typo in the endpoint path (e.g. /connections → /connection) would go undetected. Consider asserting the URL too:

sinon.assert.calledWith(mockBitGo.get, 'https://app.bitgo.com/api/address-book/v1/connections');

[seanchen0818]

updated!

[lokesh-bitgo]

Low: getConnections has a no-params test verifying undefined → {} (the ?? {} path), but getListingEntryContacts and getListingEntryDirectory only have one test each (with params). Consider adding a no-params case for both:

it('should work with no params', async function () {
  const { queryStub } = makeGetStub();
  await addressBook.getListingEntryContacts();
  sinon.assert.calledWith(queryStub, {});
});

[seanchen0818]

updated!

[lokesh-bitgo]

Nit: GetAddressBookConnectionsParams includes array fields (ownerWalletId?: string[], targetWalletId?: string[]). Superagent's default .query() serializes arrays as repeated keys — ?ownerWalletId=a&ownerWalletId=b. Worth verifying the address-book service parses that format (vs bracket notation ownerWalletId[]=a or comma-separated). If the format doesn't match, these filters would silently not work.

[seanchen0818]

updated!