Varkopat/feature/658/implement new teachersignincard component#663
Open
Varkopat wants to merge 10 commits into
Open
Varkopat/feature/658/implement new teachersignincard component#663Varkopat wants to merge 10 commits into
Varkopat wants to merge 10 commits into
Conversation
… room for the new card.
- Created TeacherSignInCard component for teacher sign-in functionality. - Added styles for the TeacherSignInCard in TeacherSignInCard.module.scss. - Implemented visibility toggle for username and password fields. - Integrated ALT logo and teacher character images. - Set up routing to navigate to the instructions page upon form submission. TODO: Adjust UI to match Figma Designs.
…design consistency
…siveness. I centered the input/button rail while keeping the Figma dimensions: .Form is now centered inside .Card. .UsernameInput and .PasswordInput keep 438.51px x 54.54px, but now use box-sizing: border-box so padding does not push them off-center. Input wrappers and form groups center their children. .SubmitButton keeps its Figma size and is centered with flex alignment. Verification passed without ESLint warnings or errors: npm.cmd run lint -- --file src/features/TeacherSignIn/ui/TeacherSignInCard/TeacherSignInCard.tsx
…s on smaller screens
Varkopat
requested review from
Rutjake,
Skoivumaki,
leolabdev and
patinen
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Pull Request Overview
Closes #658
🔧 Changes Made
Implemented and polished the teacher sign-in card UI.
Key changes:
.Containerand.Cardlayout to center the card properly..SubmitButtonstyling, spacing, sizing, border, and text alignment.npm.cmd run lint -- --file src/features/TeacherSignIn/ui/TeacherSignInCard/TeacherSignInCard.tsx.A few clean-up notes:
VisibilityIconcomponent for both username and password toggles instead of duplicating inline SVGs.box-sizing: border-boxto preserve Figma dimensions while keeping padding from shifting inputs.TeacherSignInCardstyles and markup.✅ Checklist Before Submission
console.log()or other debugging statements are left.📝 Additional Information
Provide any additional context or information that reviewers may need to know: