Skip to content

fix warning final-dtor-non-final-class#15490

Merged
shahor02 merged 1 commit into
AliceO2Group:devfrom
f3sch:fix/warn/dtor
Jun 17, 2026
Merged

fix warning final-dtor-non-final-class#15490
shahor02 merged 1 commit into
AliceO2Group:devfrom
f3sch:fix/warn/dtor

Conversation

@f3sch

@f3sch f3sch commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Fixes these compilation warnings that started showing up after updating:

2026-06-04@21:16:17:DEBUG:O2:O2:0: /Users/f3sch/git/alice/sw/SOURCES/O2/dev_head/0/Detectors/EMCAL/base/include/EMCALBase/NonlinearityHandler.h:202:43: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
2026-06-04@21:16:17:DEBUG:O2:O2:0:   191 |   class FunctionNotFoundExcpetion : public std::exception
2026-06-04@21:16:17:DEBUG:O2:O2:0:       |                                   final
2026-06-04@21:16:17:DEBUG:O2:O2:0:   192 |   {
2026-06-04@21:16:17:DEBUG:O2:O2:0:   193 |    public:
2026-06-04@21:16:17:DEBUG:O2:O2:0:   194 |     /// \brief Constructor
2026-06-04@21:16:17:DEBUG:O2:O2:0:   195 |     /// \param Name of the nonlinearity function raising the exception
2026-06-04@21:16:17:DEBUG:O2:O2:0:   196 |     FunctionNotFoundExcpetion(const std::string_view name) : mName(name), mMessage()
2026-06-04@21:16:17:DEBUG:O2:O2:0:   197 |     {
2026-06-04@21:16:17:DEBUG:O2:O2:0:   198 |       mMessage = "Nonlinearity funciton " + mName + " not found";
2026-06-04@21:16:17:DEBUG:O2:O2:0:   199 |     }
2026-06-04@21:16:17:DEBUG:O2:O2:0:   200 |
2026-06-04@21:16:17:DEBUG:O2:O2:0:   201 |     /// \brief Destructor
2026-06-04@21:16:17:DEBUG:O2:O2:0:   202 |     ~FunctionNotFoundExcpetion() noexcept final = default;
2026-06-04@21:16:17:DEBUG:O2:O2:0:       |                                           ^

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 38b36cd at 2026-06-10 21:18:

## sw/BUILD/O2Physics-latest/log
CMake Error at /sw/slc9_x86-64/CMake/v4.1.4-2/share/cmake-4.1/Modules/CMakeTestCCompiler.cmake:67 (message):
    ninja: build stopped: subcommand failed.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/455ccfeda07ed67438df4c05666a4c392d16b687/slc9_x86-64/o2checkcode/1.0-local3/etc/modulefiles
++ alibuild-generate-module
+ HAS_BIN=
+ HAS_LIB=
+ HAS_CMAKE=
+ HAS_ROOT=
+ '[' 0 '!=' 0 ']'
+ cat
+ printf 'if ![ is-loaded '\''BASE/1.0'\'' ] {\n module load BASE/1.0\n}'
+ echo 'BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release'
BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release
+ FULL_BUILD_REQUIRES='json-c MPFR safe_int CMake O2-customization Alice-GRID-Utils UUID pytorch_cpuinfo googlebenchmark double-conversion alibuild-recipe-tools ninja-fortran Python-modules-list defaults-release date FairCMakeModules ninja bz2'
+ echo 'FULL_BUILD_REQUIRES=json-c MPFR safe_int CMake O2-customization Alice-GRID-Utils UUID pytorch_cpuinfo googlebenchmark double-conversion alibuild-recipe-tools ninja-fortran Python-modules-list defaults-release date FairCMakeModules ninja bz2'
FULL_BUILD_REQUIRES=json-c MPFR safe_int CMake O2-customization Alice-GRID-Utils UUID pytorch_cpuinfo googlebenchmark double-conversion alibuild-recipe-tools ninja-fortran Python-modules-list defaults-release date FairCMakeModules ninja bz2
++ env
++ cut -f1 -d=
++ grep -v '^DEFAULT_'
++ grep -v PKGREVISION
++ grep -v ALIBUILD_RECIPE_TOOLS
++ sed -e s/_REVISION//
++ grep REVISION
+ for x in $(env | cut -f1 -d= | grep -v "^DEFAULT_" | grep -v PKGREVISION | grep -v ALIBUILD_RECIPE_TOOLS | grep REVISION | sed -e 's/_REVISION//')
++ eval 'echo $LIBFFI_REVISION'
+++ echo 10
+ REVISION_VALUE=10
++ eval 'echo $LIBFFI_VERSION'
+++ echo v3.2.1-alice1
+ VERSION_VALUE=v3.2.1-alice1
++ eval 'echo $LIBFFI_ROOT'
+++ echo /sw/slc9_x86-64/libffi/v3.2.1-alice1-10
+ ROOT_PATH_VALUE=/sw/slc9_x86-64/libffi/v3.2.1-alice1-10
+ '[' -z 10 ']'
+ echo 'json-c MPFR safe_int CMake O2-customization Alice-GRID-Utils UUID pytorch_cpuinfo googlebenchmark double-conversion alibuild-recipe-tools ninja-fortran Python-modules-list defaults-release date FairCMakeModules ninja bz2'
+ tr '[:lower:]' '[:upper:]'
+ tr - _
[0 more errors; see full log]

Full log here.

@f3sch

f3sch commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

@shahor02 I think there are no complaints about this, maybe we can just merge?

@shahor02 shahor02 merged commit e8acf47 into AliceO2Group:dev Jun 17, 2026
13 checks passed
@f3sch f3sch deleted the fix/warn/dtor branch June 17, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants