fix(core): use backtick-escaped constant reference for enum default values#99
Merged
mfabisiak merged 1 commit intoJun 19, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Kotlin model generation for enum-valued defaults when the generated enum constant name is not a valid Kotlin identifier (e.g., "1"), ensuring KotlinPoet emits a backtick-escaped constant reference so generated code compiles.
Changes:
- Switch enum default-value emission from KotlinPoet’s
%Lto%Nso invalid identifiers get backtick-escaped automatically. - Add a regression test that asserts numeric-string enum defaults produce backtick-escaped references.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/src/main/kotlin/com/avsystem/justworks/core/gen/model/ModelGenerator.kt | Uses %N for enum constant references in default values to trigger KotlinPoet escaping. |
| core/src/test/kotlin/com/avsystem/justworks/core/gen/ModelGeneratorTest.kt | Adds a regression test for a numeric-string enum default value to prevent reintroducing the compile error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report
|
janwawszczak
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an enum value produces a constant name that is not a valid Kotlin
identifier (e.g. "1" →
1), the generated default value was emittedwithout backticks, causing a compilation error:
Using
%Ninstead of%Lin KotlinPoet's CodeBlock lets the libraryapply backtick escaping automatically:
Adds a regression test covering a numeric-string enum default.