Add Moss Desktop release workflow#212
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53c8a67ac3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - name: Verify runtime and source gates | ||
| run: | | ||
| bun run test:runtime |
There was a problem hiding this comment.
In the tree for this commit, package.json does not define test:runtime, release:credentials:strict, test:packaged-app-smoke, release:notarize, or release:evidence:audit, and repo-wide lookup also shows scripts/upload-release.mjs and scripts/verify-release-packaging.mjs are absent. A manual workflow_dispatch therefore exits at this first bun run test:runtime with Script not found before any macOS release artifact can be built, so the workflow needs to commit those scripts or call commands that already exist.
Useful? React with 👍 / 👎.
|
Updated the PR branch to include the verified runtime support closure. Current PR head: 8405ba7 Evidence:
Remaining external release gates after merge: GitHub workflow visibility on upstream, Apple signing/notarization secrets, and a real non-dry-run notarized CI evidence package. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8405ba70ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "test:runtime": "bun test src/main/lib/moss-account/entitlement.test.ts src/main/lib/moss-source/provider-config.test.ts src/main/lib/mcp-stdio-compat.test.ts src/main/lib/trpc/routers/chat-runtime-selection.test.ts src/main/lib/trpc/routers/codex-mcp-session.test.ts src/main/lib/codex-automations.test.ts src/shared/codex-runtime-notices.test.ts", | ||
| "release:credentials:strict": "node scripts/verify-release-credentials.mjs --require-credentials", | ||
| "test:packaged-app-smoke": "node scripts/smoke-packaged-app.mjs", | ||
| "release:notarize": "node scripts/notarize-release-artifacts.mjs", | ||
| "release:evidence:audit": "node scripts/audit-release-evidence.mjs" |
There was a problem hiding this comment.
Fresh evidence: although this block adds the scripts named in the earlier review, the new release gates now unconditionally require additional scripts that still are not defined (release:credentials in scripts/verify-release-credentials.mjs:117, plus verify:program, release:ci, release:local, and dist:upload:dry-run in scripts/verify-release-packaging.mjs). On workflow_dispatch, bun run release:credentials:strict invokes the preflight and exits non-zero before packaging, and the final verifier would fail for the remaining missing scripts, so the macOS release workflow still cannot complete.
Useful? React with 👍 / 👎.
|
Updated PR #212 again with the remaining verified runtime support closure. Current PR head is now |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ee0d297a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| engine: text("engine").notNull().default("claude-code"), // "claude-code" | "codex" | "hermes" | "custom-acp" | ||
| engineSessionId: text("engine_session_id"), // Native engine session ID for resume | ||
| engineConfigDir: text("engine_config_dir"), // Per-engine config/session projection dir | ||
| modelId: text("model_id"), // Last selected runtime model for this sub-chat | ||
| runtimeMetadata: text("runtime_metadata"), // JSON object for engine-specific metadata |
There was a problem hiding this comment.
These columns are added to the Drizzle schema, but this commit does not add a corresponding drizzle/*.sql migration; I checked the migration files in this tree and none add engine, engine_session_id, engine_config_dir, model_id, or runtime_metadata. On an existing user database, migrate() will leave sub_chats at the old shape, and the new selects/inserts that reference subChats.engine and friends will fail with SQLite no such column errors as soon as chats or mobile gateway sessions are loaded.
Useful? React with 👍 / 👎.
|
|
||
| const send = () => { | ||
| if (!win.isDestroyed()) { | ||
| win.webContents.send("plugin:open-detail", target) |
There was a problem hiding this comment.
When a twentyfirst-agents://plugins/... link is received, this sends plugin:open-detail, but a repo-wide search shows this is the only occurrence of that channel; the preload bridge does not register or expose it, and the renderer has no listener. With context isolation enabled, the renderer never sees this message, so plugin deep links only focus the window instead of opening the requested plugin detail or try-in-chat surface.
Useful? React with 👍 / 👎.
1 participant
Publishes only .github/workflows/moss-desktop-release.yml so the notarized macOS release workflow can run.\n\nEvidence from the isolated publication worktree:\n- changed path: .github/workflows/moss-desktop-release.yml\n- prepared commit: 53c8a67\n- main worktree dirty state was not pushed