From 4fa6d01e1565952a52f4aa874c8716d1f5b22bc8 Mon Sep 17 00:00:00 2001 From: Alex Ross <38270282+alexr00@users.noreply.github.com> Date: Fri, 3 Jul 2026 11:26:25 +0200 Subject: [PATCH] Handle unknown checks case Fixes #8813 --- src/github/markdownUtils.ts | 2 ++ src/github/utils.ts | 3 ++- src/view/prsTreeModel.ts | 7 ++++--- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/github/markdownUtils.ts b/src/github/markdownUtils.ts index cf4c766af7..4d5f77cce9 100644 --- a/src/github/markdownUtils.ts +++ b/src/github/markdownUtils.ts @@ -346,6 +346,8 @@ export function getStatusDecoration(status: UnsatisfiedChecks): vscode.FileDecor badge: new vscode.ThemeIcon('circle-filled', new vscode.ThemeColor('list.warningForeground')), tooltip: 'Review required' }; + } else if (status & UnsatisfiedChecks.Unknown) { + return; } else if (status === UnsatisfiedChecks.None) { return { propagate: false, diff --git a/src/github/utils.ts b/src/github/utils.ts index 8c652f92f5..631d6c641e 100644 --- a/src/github/utils.ts +++ b/src/github/utils.ts @@ -1984,7 +1984,8 @@ export enum UnsatisfiedChecks { ReviewRequired = 1 << 0, ChangesRequested = 1 << 1, CIFailed = 1 << 2, - CIPending = 1 << 3 + CIPending = 1 << 3, + Unknown = 1 << 4 } export async function extractRepoFromQuery(folderManager: FolderRepositoryManager, query: string | undefined): Promise { diff --git a/src/view/prsTreeModel.ts b/src/view/prsTreeModel.ts index a646e91f71..7a2ecc0824 100644 --- a/src/view/prsTreeModel.ts +++ b/src/view/prsTreeModel.ts @@ -262,9 +262,10 @@ export class PrsTreeModel extends Disposable { } if (!check || check.state === CheckState.Unknown) { - continue; - } - if (check.state !== CheckState.Success) { + if (newStatus === UnsatisfiedChecks.None) { + newStatus |= UnsatisfiedChecks.Unknown; + } + } else if (check.state !== CheckState.Success) { for (const status of check.statuses) { if (status.state === CheckState.Failure) { newStatus |= UnsatisfiedChecks.CIFailed;